Conversation
isc-dchui
requested review from
isc-cborbonm,
isc-egabhart,
isc-eneil,
isc-jili,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-kiyer
requested changes
Apr 2, 2026
Collaborator
isc-kiyer
left a comment
isc-kiyer
left a comment
There was a problem hiding this comment.
@isc-dchui 2 small comments
isc-kiyer
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1112
The main issue is that SourceRoot was being ignored by the globals resource processor during export but not during reload, so packaging a module with a globals resource would not include the file in the correct location. This change fixes it by making both export and (re)load respect the SourceRoot.
Testing
New integration test based on the data in the wiki.:
Test.PM.Integration.GlobalsPackagingChecklist
mainbranch rebased or merged.zpm test -only) and integration tests (zpm verify -only) pass.