feat(pull-secret): add pull secret management commands#80
Open
Benedicte Brandsnes Nyheim (benedictebn) wants to merge 6 commits intomainfrom
Open
feat(pull-secret): add pull secret management commands#80Benedicte Brandsnes Nyheim (benedictebn) wants to merge 6 commits intomainfrom
Benedicte Brandsnes Nyheim (benedictebn) wants to merge 6 commits intomainfrom
Conversation
Contributor
|
Har patchet prosjektet siden du la inn denne. Trenger nok en rebase. La oss ta en runde og se over de nye kommandoene først vi merger. Si ifra når det er klart. |
Benedicte Brandsnes Nyheim (benedictebn)
force-pushed
the
feat/pull-secret-support
branch
from
32d6be3 to
0d2e5da
Compare
…tegration Add full CRUD support for image pull secrets (list, get, create, edit, delete), a cluster pull-secret set command, pull secret selection in the cluster create wizard, and pull secret display in cluster get output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix line length by extracting endpoint variables - Fix cyclomatic complexity by extracting resolvePullSecretRef - Fix function length by extracting wizard helpers into wizard.go - Fix argument limit by using editOptions struct - Add yaml struct tags to PullSecret for musttag - Wrap FindPullSecretByName error for wrapcheck - Preallocate psOptions slice Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Password field is a credential payload sent to the API, not a hardcoded secret. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Benedicte Brandsnes Nyheim (benedictebn)
force-pushed
the
feat/pull-secret-support
branch
from
0d2e5da to
5145cf9
Compare
…mands Remove interactive wizard from create/edit commands and introduce a hierarchical `registry` subcommand group (add/remove) mirroring the teams member management pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Benedicte Brandsnes Nyheim (benedictebn)
requested a review
from Marius MJ (M99)
- Add registry flags (--address, --username, --password) to pull-secret create, as the backend requires at least one registry at creation time - Fix dev backend port from 8080 to 8081 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull-secret list/get/create/delete)pull-secret registry add/remove(following theteam member add/removepattern)cluster pullsecret setcommand to assign secrets to clusters--pull-secretflag oncluster createcluster getoutputPullSecretClientinterface and REST methods added to platform client, plusImagePullSecretfield to theClusterstructTest plan
Pull secret management
indev pull-secret create -n my-secret -a ghcr.io -u myuser --password mytoken— creates a new pull secret with an initial registryindev pull-secret list— lists all pull secretsindev pull-secret list -o wide— lists with ID and created-at columnsindev pull-secret list -o json/-o yaml— machine-readable outputindev pull-secret get my-secret— shows details including attached registriesindev pull-secret delete my-secret— deletes the pull secretRegistry management
indev pull-secret registry add -p my-secret -a docker.io -u myuser --password mytoken— adds an additional registry with credentialsindev pull-secret registry remove -p my-secret -a docker.io— removes a registry from a pull secretCluster integration
indev cluster create -n my-cluster --pull-secret my-secret— creates a cluster with a pull secret attachedindev cluster create(interactive wizard) — pull secret selection appears in wizard when pull secrets existindev cluster pullsecret set my-cluster my-secret— assigns a pull secret to an existing clusterError cases
indev pull-secret createwithout--namereturns a clear errorindev pull-secret create -n my-secretwithout registry flags returns a clear errorindev pull-secret registry addwith missing flags returns a clear errorindev cluster pullsecret setwith a non-existent pull secret name returns a clear error🤖 Generated with Claude Code