RMET-4099 :: minor bug fixing and use media processor for edit photos#3
Merged
OS-ruimoreiramendes merged 26 commits intofeat/RMET-4099/android-implementationfrom Mar 16, 2026
Conversation
Did not update other dependencies to keep changes at a minimum for now. Also did not update mockito to latest versions as mockito-core latest may require JDK 21, which we're not using yet, and mockito-kotlin may require Kotlin 2, which we're not using yet either.
Was still using OSCAMRController
Was still using OSCAMRController
Was still using OSCAMRController I had to replace some URIs that were arriving as null with Uri.parse, but it wasn't affecting the current tests for reasons that I did not fully comprehend. Regardless, the uri content itself was irrelevant for the tests results.
Was still using OSCAMRController
Was still using OSCAMRController
Was still using OSCAMRController Because the Manager calls some different methods from OSCAMRController because it's isolated, had to add some missing mocking for some tests to pass
Commenting Sonarqube steps for now, until we are able to configure Sonarqube in Ionic repos
All logic split into managers now, controller "god class" no longer needed
…change photos location
…9/save-photos-location
src/main/kotlin/io/ionic/libs/ioncameralib/helper/IONCAMRMediaHelperInterface.kt
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ioncameralib/view/IONImageEditorView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ioncameralib/processor/IONCAMRMediaProcessor.kt
Show resolved
Hide resolved
4 tasks
src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRMediaResult.kt
Outdated
Show resolved
Hide resolved
OS-pedrogustavobilro
approved these changes
Mar 16, 2026
OS-ruimoreiramendes
merged commit 72b5a5d
into
feat/RMET-4099/android-implementation
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.