Conversation
isXander
left a comment
There was a problem hiding this comment.
Love this! Thank you for the contribution.
|
I think it best not to clutter the interface even more with a toggle. It makes sense that a search box should search everything, not just the current tab. One suggestion though, might be a bit tricky. Because entering in a non-matching search will change tabs automatically, the current tab should always prefer to be the originally selected tab if any results come up. |
ce2564b to
81f9e9b
Compare
|
I think I managed to do that |
|
|
||
| @Override | ||
| public boolean mouseClicked(double mouseX, double mouseY, int button /*? if >=1.21.9 {*/ ,boolean doubleClick /*?}*/) { | ||
| preferredTab = null; |
There was a problem hiding this comment.
This means keyboard and controller navigation will not update this. You aught to find a better place for this to go in order to be a bit more abstract about it.
There was a problem hiding this comment.
ah right
um
maybe in setFocused?
1b14459 to
ce5afc4
Compare
Grays out tabs where the result isn't and moves you automatically to the next tab.
Not sure if this is an implementation you like.
Someone suggested to add a toggle for the global search above the search bar or something, tell me if you think it's a good idea.