Skip to content

Finalise marks database migration#763

Merged
jsharkey13 merged 5 commits intomainfrom
improvement/marks-migration
Mar 27, 2026
Merged

Finalise marks database migration#763
jsharkey13 merged 5 commits intomainfrom
improvement/marks-migration

Conversation

@sjd210
Copy link
Copy Markdown
Contributor

@sjd210 sjd210 commented Mar 3, 2026

Database migration for the work to start using a "marks" field in #731.

For sites with LLM-marked questions enabled (local/staging/all of Ada), this migration involves either
a) reading the "marks" field from the question_attempt JSON for LLM-marked questions
b) using the correct column to determine marks, with 0 marks for an incorrect attempt and 1 mark for a correct attempt for all other questions

For sites without LLM-marked questions enabled (Isaac live), we stick with just the simpler (b) - which is convenient since this is the much larger database. The relevant functions will need to be uncommented for this.

Also to note: this "marks" field has been written to since mid-January, however this script runs up to the present and so will override the values currently in the column. Not much time has passed, and it should do so with the exact same values so I don't think this is a big deal.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.94%. Comparing base (72414b9) to head (54dd980).
⚠️ Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   39.94%   39.94%           
=======================================
  Files         546      546           
  Lines       23907    23907           
  Branches     2873     2873           
=======================================
  Hits         9550     9550           
  Misses      13450    13450           
  Partials      907      907           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjd210 sjd210 marked this pull request as ready for review March 3, 2026 15:20
@sjd210
Copy link
Copy Markdown
Contributor Author

sjd210 commented Mar 27, 2026

@jsharkey13 If the migration has now been done on all sites, shall we merge this?

@jsharkey13 jsharkey13 merged commit de4c1df into main Mar 27, 2026
5 checks passed
@jsharkey13 jsharkey13 deleted the improvement/marks-migration branch March 27, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants