(fix) Proposing to collect empty separation lines with comments#68
(fix) Proposing to collect empty separation lines with comments#68MementoRC wants to merge 4 commits intoisidentical:mainfrom
Conversation
|
To pass the test, the proposed |
|
The issue was due to collecting empty lines after the node to replace and somehow double counting them in some cases. Restoring the original test. It would be good to look more closely, the new unparser created duplicated newlines in the insert_after test at the |
isidentical
left a comment
There was a problem hiding this comment.
Regarding the test failures, if textwrap.dedent is doing something it shouldn't do (e.g. if the result is more precise without it, I think it makes a lot of sense to remove it and maybe use something else.
This is not fully tested, in particular the added test fails because the :
cannot hold a line of spaces, but the modification automatically produces them, so the test fails with no possibility to make it pass (maybe this is a
dedentpeculiarity?)