Added release.json generation to builds#2
Open
tuj wants to merge 3 commits intofeature/3x-github-packagesfrom
Open
Added release.json generation to builds#2tuj wants to merge 3 commits intofeature/3x-github-packagesfrom
tuj wants to merge 3 commits intofeature/3x-github-packagesfrom
Conversation
turegjorup
requested changes
Mar 31, 2026
|
|
||
| - name: Create release file | ||
| run: | | ||
| printf "{\n \"releaseTimestamp\": $(date +%s),\n \"releaseTime\": \"$(date)\",\n \"releaseVersion\": \"${{ github.ref_name }}\"\n}" > public/release.json |
There was a problem hiding this comment.
We should run name: Set release timestamp first, then use those values here. Otherwise we get slightly different timestamps.
|
|
||
| ARG APP_VERSION="develop" | ||
| ARG APP_RELEASE_TIMESTAMP=0 | ||
| ARG APP_RELEASE_TIME="" |
There was a problem hiding this comment.
Could we do default values similar to
--build-arg APP_RELEASE_TIME="$(date)" \
--build-arg APP_RELEASE_TIMESTAMP="$(date +%s)" \
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
os2display#371
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/6871
Description
Adds release.json generation to builds.
Builds on:
https://github.com/os2display/display-client/blob/develop/.github/workflows/github_build_release.yml#L28
https://github.com/os2display/display-client/blob/develop/infrastructure/itkdev/run.sh#L10
https://github.com/os2display/display-client/blob/develop/infrastructure/itkdev/Dockerfile#L44
https://github.com/os2display/display-client/blob/develop/.github/workflows/itkdev_docker_build_develop.yml#L36
Checklist