Skip to content

Attempting to do CI to run unit tests on all PRs. #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LowAmmo wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Attempting to do CI to run unit tests on all PRs. #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7645e81
Attempting to do CI to run unit tests on all PRs.
LowAmmo Mar 19, 2026
96581e0
Specify "iPhone 17"
LowAmmo Mar 19, 2026
c82e40f
Adding .xctestplans into the xcode project file and remo
LowAmmo Mar 19, 2026
c93cd9f
Generate code coverage
LowAmmo Apr 7, 2026
78d6363
Add code coverage results
LowAmmo Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions .github/workflows/pull-request-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
name: Pull Request CI

on:
pull_request:
workflow_dispatch:

concurrency:
group: pull-request-ci-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
unit-tests:
name: Unit Tests (${{ matrix.scheme }})
runs-on: macos-latest
strategy:
fail-fast: false
matrix:
scheme:
- libPhoneNumber
- libPhoneNumberGeocoding
- libPhoneNumberShortNumber

steps:
- name: Check out repository
uses: actions/checkout@v4

- name: Run unit tests
env:
SCHEME: ${{ matrix.scheme }}
run: |
set -eo pipefail
mkdir -p TestResults

xcodebuild \
-project libPhoneNumber.xcodeproj \
-scheme "$SCHEME" \
-destination 'platform=iOS Simulator,OS=latest,name=iPhone 17' \
-resultBundlePath "TestResults/${SCHEME}.xcresult" \
-enableCodeCoverage YES \
CODE_SIGNING_ALLOWED=NO \
test

- name: Upload unit test results
if: always()
uses: actions/upload-artifact@v4
with:
name: project-unit-tests-${{ matrix.scheme }}
path: TestResults/${{ matrix.scheme }}.xcresult

podspec-lint:
name: Podspec Lint (${{ matrix.podspec }})
runs-on: macos-latest
strategy:
fail-fast: false
matrix:
podspec:
- libPhoneNumber-iOS.podspec
- libPhoneNumberGeocoding.podspec
- libPhoneNumberShortNumber.podspec

steps:
- name: Check out repository
uses: actions/checkout@v4

- name: Ensure CocoaPods is installed
run: |
if ! command -v pod >/dev/null; then
gem install cocoapods
fi

- name: Lint podspec
run: pod lib lint "${{ matrix.podspec }}" --verbose
71 changes: 20 additions & 51 deletions libPhoneNumber.xcodeproj/project.pbxproj
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 9 additions & 4 deletions libPhoneNumber.xcodeproj/xcshareddata/xcschemes/libPhoneNumber.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1640"
LastUpgradeVersion = "2640"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
buildImplicitDependencies = "NO">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
Expand All @@ -26,8 +26,13 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
shouldAutocreateTestPlan = "YES">
shouldUseLaunchSchemeArgsEnv = "YES">
<TestPlans>
<TestPlanReference
reference = "container:libPhoneNumberTests/libPhoneNumberTests.xctestplan"
default = "YES">
</TestPlanReference>
</TestPlans>
<Testables>
<TestableReference
skipped = "NO">
Expand Down
22 changes: 8 additions & 14 deletions libPhoneNumber.xcodeproj/xcshareddata/xcschemes/libPhoneNumberGeocoding.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1640"
LastUpgradeVersion = "2640"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
buildImplicitDependencies = "NO">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
Expand All @@ -27,18 +27,12 @@
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "0FC0D37524A2A05E0087AFCF"
BuildableName = "libPhoneNumberGeocodingTests.xctest"
BlueprintName = "libPhoneNumberGeocodingTests"
ReferencedContainer = "container:libPhoneNumber.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
<TestPlans>
<TestPlanReference
reference = "container:libPhoneNumberGeocodingTests/libPhoneNumberGeocodingTests.xctestplan"
default = "YES">
</TestPlanReference>
</TestPlans>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
Expand Down
24 changes: 9 additions & 15 deletions libPhoneNumber.xcodeproj/xcshareddata/xcschemes/libPhoneNumberShortNumber.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1640"
version = "1.3">
LastUpgradeVersion = "2640"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
buildImplicitDependencies = "NO">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
Expand All @@ -27,18 +27,12 @@
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "9407259224BE768A0011AE05"
BuildableName = "libPhoneNumberShortNumberTests.xctest"
BlueprintName = "libPhoneNumberShortNumberTests"
ReferencedContainer = "container:libPhoneNumber.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
<TestPlans>
<TestPlanReference
reference = "container:libPhoneNumberShortNumberTests/libPhoneNumberShortNumberTests.xctestplan"
default = "YES">
</TestPlanReference>
</TestPlans>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
Expand Down
14 changes: 11 additions & 3 deletions libPhoneNumberGeocodingTests/libPhoneNumberGeocodingTests.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,23 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"codeCoverage" : {
"targets" : [
{
"containerPath" : "container:libPhoneNumber.xcodeproj",
"identifier" : "0FC0D36324A29F510087AFCF",
"name" : "libPhoneNumberGeocoding"
}
]
},
"testExecutionOrdering" : "random"
},
"testTargets" : [
{
"parallelizable" : false,
"target" : {
"containerPath" : "container:",
"identifier" : "libPhoneNumberGeocodingTests",
"containerPath" : "container:libPhoneNumber.xcodeproj",
"identifier" : "0FC0D37524A2A05E0087AFCF",
"name" : "libPhoneNumberGeocodingTests"
}
}
Expand Down
13 changes: 11 additions & 2 deletions libPhoneNumberShortNumberTests/libPhoneNumberShortNumberTests.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,23 @@
}
],
"defaultOptions" : {
"codeCoverage" : {
"targets" : [
{
"containerPath" : "container:libPhoneNumber.xcodeproj",
"identifier" : "9407258A24BE768A0011AE05",
"name" : "libPhoneNumberShortNumber"
}
]
},
"testExecutionOrdering" : "random"
},
"testTargets" : [
{
"parallelizable" : false,
"target" : {
"containerPath" : "container:",
"identifier" : "libPhoneNumberShortNumberTests",
"containerPath" : "container:libPhoneNumber.xcodeproj",
"identifier" : "9407259224BE768A0011AE05",
"name" : "libPhoneNumberShortNumberTests"
}
}
Expand Down
13 changes: 11 additions & 2 deletions libPhoneNumberTests/libPhoneNumberTests.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,23 @@
}
],
"defaultOptions" : {
"codeCoverage" : {
"targets" : [
{
"containerPath" : "container:libPhoneNumber.xcodeproj",
"identifier" : "34ACBB841B7122AC0064B3BD",
"name" : "libPhoneNumber"
}
]
},
"testExecutionOrdering" : "random"
},
"testTargets" : [
{
"parallelizable" : false,
"target" : {
"containerPath" : "container:",
"identifier" : "libPhoneNumberTests",
"containerPath" : "container:libPhoneNumber.xcodeproj",
"identifier" : "14B7A2921DE9B65D0051AED7",
"name" : "libPhoneNumberTests"
}
}
Expand Down
Loading