Skip to content

Upgrade to Gradle 9.4.1 #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
8Keep wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Upgrade to Gradle 9.4.1 #2696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
3 changes: 2 additions & 1 deletion jme3-screenshot-tests/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ dependencies {
implementation 'com.aventstack:extentreports:5.1.2'
implementation platform('org.junit:junit-bom:5.9.1')
implementation 'org.junit.jupiter:junit-jupiter'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Gradle 9, the junit-platform-launcher is required at runtime for executing JUnit 5 tests. Since jme3-screenshot-tests acts as a test framework for other modules (providing base classes in src/main), changing this to runtimeOnly ensures the launcher is transitively available to all consumers of this module. This avoids the need to manually add the launcher to every module's dependencies and ensures consistent test execution across the project.

    runtimeOnly 'org.junit.platform:junit-platform-launcher'

testRuntimeOnly project(':jme3-testdata')
}

Expand All @@ -35,4 +36,4 @@ test {
excludeTags 'integration'
}
}
}
}
Loading