feat(pipeline): add numeric comparison mode to sort step#306
Open
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Open
feat(pipeline): add numeric comparison mode to sort step#306Astro-Han wants to merge 1 commit intojackwener:mainfrom
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Conversation
When APIs return numeric values as strings (e.g. "1234567.89"), sort used lexicographic ordering. Add `numeric: true` option to convert values via Number() before comparison, with Number.isFinite guard for non-numeric fallback to 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
numeric: trueoption to the pipelinesortstep so string-encoded numbers are compared numerically instead of lexicographically.When APIs return numeric values as strings (e.g.
"quoteVolume": "1234567.89"), the sort step uses lexicographic ordering, causing"99"to rank above"1000". Withnumeric: true, values are converted viaNumber()with aNumber.isFinite()guard before comparison.Closes #304
Type of Change
Checklist
Screenshots / Output