fix(execution): apply timeout to non-browser commands#383
Open
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Open
fix(execution): apply timeout to non-browser commands#383Astro-Han wants to merge 1 commit intojackwener:mainfrom
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Conversation
43bb28e to
853542e
Compare
18f4551 to
80bd70e
Compare
Non-browser commands (`browser: false`) ran without any timeout protection, even when `timeoutSeconds` was explicitly set. This wraps the non-browser execution path with `runWithTimeout()` when the adapter defines a positive `timeoutSeconds`. Also adds an optional `hint` parameter to `TimeoutError` so the non-browser path shows a relevant suggestion instead of the browser-specific `OPENCLI_BROWSER_COMMAND_TIMEOUT` env var hint.
3459301 to
52512da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-browser commands (
browser: false) ran without any timeout protection, even when the adapter explicitly settimeoutSeconds. The browser branch already wrapped execution withrunWithTimeout(), but the non-browser branch calledrunCommand()directly.This adds the same
runWithTimeout()wrapping when a positivetimeoutSecondsis configured. Also adds an optionalhinttoTimeoutErrorso non-browser timeouts show a relevant message instead of the browser-specific env var hint.Related issue: fixes the non-browser timeout gap identified in code audit
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorScreenshots / Output