fix(pipeline): check HTTP status in fetch step#384
Open
Astro-Han wants to merge 5 commits intojackwener:mainfrom
Open
fix(pipeline): check HTTP status in fetch step#384Astro-Han wants to merge 5 commits intojackwener:mainfrom
Astro-Han wants to merge 5 commits intojackwener:mainfrom
Conversation
Contributor
Author
|
Updated this PR after follow-up review. What changed:
Follow-up (review round 2):
Validation:
|
- Replace bare Error with CliError('FETCH_ERROR') for consistent CLI output
- Return error status from browser evaluate instead of throwing inside it
- Add log.warn() for batch item failures in both browser and non-browser paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalize HTTP error handling in the pipeline
fetchstep. Single-request fetches now fail fast on non-ok responses, while per-item batch fetches return per-item{ error }objects consistently in both browser and non-browser execution.Behavior note: non-ok responses are no longer parsed as successful data. Single fetches throw immediately; batch fetches preserve per-item error objects instead of mixing browser/non-browser semantics.
Related issue: N/A
Type of Change
Checklist
Test Plan
npx vitest run src/pipeline/steps/fetch.test.tsnpm run typechecknpm testSummary
{ error }resultsScreenshots / Output
Not applicable.