Change import such that TS can infer type#4
Merged
jacobheun merged 1 commit intojacobheun:masterfrom May 25, 2020
Merged
Conversation
Owner
|
It looks like there is an issue with the abort-controller exports for browsers which causes AbortController to be undefined. https://github.com/mysticatea/abort-controller/blob/master/browser.js#L11-L13 is missing |
Owner
|
I created a PR to abort-controller to fix the browser export, mysticatea/abort-controller#22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this is used from the typescript most things can be inferred, except for
AbortControllerwhich has it types defined as ES module (see https://github.com/mysticatea/abort-controller/blob/master/dist/abort-controller.d.ts)TS does not interpret
default exportasmodule.exportswhich leads to problems downstream. This change just uses named import that is also providedabort-controllerwhich resolves all the issues.