Draft
Conversation
gavinking
force-pushed
the
convert-to
branch
from
cbed5fe to
ab99612
Compare
gavinking
force-pushed
the
convert-to
branch
from
ab99612 to
8b5f326
Compare
yrodiere
reviewed
Jan 14, 2026
| * | ||
| * @since 4.0 | ||
| */ | ||
| Class<?> to() default void.class; |
There was a problem hiding this comment.
I wonder if something like as() wouldn't be less confusing here... because this is fundamentally not a one-way conversion.
But then as is a keyword in Groovy, so there's that.
Member
Author
There was a problem hiding this comment.
I think if it were @Persist or @Treat then as would be better. But "convert as string" isn't grammatically correct.
Co-authored-by: Yoann Rodière <yoann@hibernate.org>
yrodiere
approved these changes
Jan 15, 2026
Member
Author
|
If we're going to touch this stuff, we should take the opportunity to bless the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #619