Conversation
|
Can you elaborate please? Or write a test? When does it fail? |
|
@fprochazka I have AdminLTE.min.css in webloader with url fixed and it completely destroys the file, it is empty, this fix is needed. //EDIT: I tested webloader with this code and it works. |
|
That's cool, but I need a testcase for it. Either I write it, which might take months till I have time for it, or you guys do it :) @juniwalk do you think you could please try to isolate the problem and write a test? Are we sure this isn't some regex platform limit problem like those errors with latte/neon ? |
|
@fprochazka Well I can try, but I'd have to open new pull since I can't commit to this one, can I? |
|
@juniwalk I don't think thats a problem, is it? You can simply cherrypick this commit to your PR. |
|
I am probably just looking into details, I will try to look where the problem lies tomorrow. |
|
@fprochazka So in // EDIT: If I just add quotes it works too, looks like missing quotes is the bottleneck |
return default css code if absolutizeUrl() failed