Fix CI failures, remove generated files from Git#9
Open
zbynek wants to merge 1 commit intojavacc:releasefrom
Open
Fix CI failures, remove generated files from Git#9zbynek wants to merge 1 commit intojavacc:releasefrom
zbynek wants to merge 1 commit intojavacc:releasefrom
Conversation
0340f78 to
2ff627e
Compare
0a95ab5 to
4891966
Compare
Contributor
|
Thank you for this great clean up! I will let @MarcMazas take a quick look and merge. |
Collaborator
Contributor
Author
|
@MarcMazas I'd like to see the other PRs merged as well, but I have to resolve the conflicts first. |
Collaborator
|
Thanks. I also would appreciate you create the same PRs for the c++ & c# versions :-). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several problems with the CI setup this PR intends to fix:
releasebranch, even for pull requests. That makes it impossible to test code before merging.no_local_java_generator_versionkicks in, meaning that integration tests use the last released version of the generator instead of the local one that should be testedfixcrlfant task makes this more robust.*.outand*.errfiles, but not files called simplyoutanderr. Fixed by renaming.