GZIPContentEncodingFilter: Object header values

[mfulton26]

Response.header(String, Object) supports non-String header values so
GZIPContentEncodingFilter should too. Otherwise Response builders may
get a ClassCastException when attempting to use non-String response
header values.

[landonvg]

Should this change have a unit test?

[mfulton26]

Probably but there are no existing unit tests for the GZIPContentEncodingFilter but that doesn't mean I can't add some. I will investigate.

[landonvg]

looks like there is the same issue on line 95; there you'll need to convert Object to String

[mfulton26]

No casting takes place on line 95. ContainerRequest.getRequestHeaders()'s return type is MultivaluedMap<String, String>.

[landonvg]

Oh, right--that's the request header, not the response header.

[mfulton26]

@mgajdos Perhaps you can answer a question for me. What are my options if I want to add a test class for this container filter but want to use a mocking framework such as Mockito? Can I pull that in as a Maven test-scope dependency?

[mfulton26]

Unit test amended (failed with ClassCastException without the change). I didn't end up needing to use a mocking framework so no additional test dependencies have been added which makes this simpler.

[mfulton26]

@mgajdos, what does the OCA label mean? Is it good or bad? i.e. Is there anything blocking this being reviewed and potentially merged? Thanks.