Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the libclang dependency management by using the libclang package from PyPI instead of requiring users to manually configure the library path via environment variables.
Changes:
- Added
libclang>=18.1.1as a project dependency inpyproject.tomlanduv.lock - Removed manual libclang path configuration code from test files and Jupyter notebook
- Removed the
PY_CPPMODEL_LIBCLANG_PATHenvironment variable requirement from test scripts and CI workflows - Updated README to remove the "Limitations" section that documented the environment variable requirement
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Added libclang 18.1.1 package with platform-specific wheels and updated package metadata |
| test_py_cppmodel.py | Removed environment variable check and manual library configuration |
| test_parse_standard_library_includes.py | Removed environment variable check and manual library configuration |
| test.macos.sh | Removed PY_CPPMODEL_LIBCLANG_PATH environment variable from test execution |
| pyproject.toml | Added libclang>=18.1.1 to project dependencies |
| Sandbox.ipynb | Removed manual libclang configuration cell and renumbered subsequent cells |
| README.md | Removed "Limitations" section and updated test instructions |
| .github/workflows/python.yml | Removed PY_CPPMODEL_LIBCLANG_PATH environment variable from CI test execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11