Avoid rerender of all images when selecting one#98
Open
akontaroudis wants to merge 4 commits intojeanpan:masterfrom
Open
Avoid rerender of all images when selecting one#98akontaroudis wants to merge 4 commits intojeanpan:masterfrom
akontaroudis wants to merge 4 commits intojeanpan:masterfrom
Conversation
Use react-native-community CameraRoll rather than the one from core react-native
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a long list of images rendered there is a noticeable lag when selecting an image. This is due to the fact that all
ImageItemcomponents are rerendered. This is simple change to makeImageItemaPureComponent.