feat: batch file remove actions#5081
Closed
PeterCardenas wants to merge 1 commit intojesseduffield:masterfrom
Closed
feat: batch file remove actions#5081PeterCardenas wants to merge 1 commit intojesseduffield:masterfrom
PeterCardenas wants to merge 1 commit intojesseduffield:masterfrom
Conversation
7ccf17a to
d4b9643
Compare
d4b9643 to
ef897c3
Compare
Collaborator
|
I'm closing this as superseded by #5407, hope you don't mind. From a cursory look it seems like yours took a similar approach, but I have to say that I find it hard to review, and it's lacking test coverage. |
Contributor
Author
|
@stefanhaller all good! glad it's getting addressed in some way. i've been meaning to add tests but haven't got around to it. one thing i did want to eventually address was an issue in the same code path where directories whose files where removed by the action are not also removed, but figured that might be a separate pr |
Collaborator
That would be #1964. I'm working on that right now. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
closes #4581
when pressing the remove keymap for files, we now group them up by the action we will perform on them, and then execute each action in bulk for all the files. This is a much faster approach than executing for each file.
some notes:
Please check if the PR fulfills these requirements
go generate ./...)* [x] Code has been formatted (see here)