Support Ctrl Modifier for Word Navigation and Deletion in Text Areas#5394
Open
iskandergaba wants to merge 1 commit intojesseduffield:masterfrom
Open
Support Ctrl Modifier for Word Navigation and Deletion in Text Areas#5394iskandergaba wants to merge 1 commit intojesseduffield:masterfrom
Ctrl Modifier for Word Navigation and Deletion in Text Areas#5394iskandergaba wants to merge 1 commit intojesseduffield:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Unlike
lazygit, most text editors and TUIs supportCtrlbased key bindings for word navigation and deletion. They also support forward word deletion. As a heavy user of these key bindings, I wanted to extend their support tolazygitto switch between tools more easily.I am sure that I am not the only one who would appreciate this, and in any case, this extension does not break any preexisting key bindings.
Changes:
Ctrl+Left/Ctrl+Right: Move cursor one word left/right (alongside existingAlt+Left/Rightand Emacs-styleAlt+B/Alt+F)Ctrl+Backspace: delete word to the left (alongside existingAlt+BackspaceandCtrl+W)Ctrl+Delete/Alt+D: Delete word to the right (new; no equivalent existed before)Note:
ModCtrlwas previously disabled ingocuiwith a comment stating it didn't work with keyboard keys. This comment was written 5 years ago and mentionstcell.v1while the project is currently usingtcell.v2, so I suspect it is a bit legacy now, but I would like it if the maintainers double-checked that part. I managed to makeModCtrlwork by patchingtcell_driver.goto preserve it for right/left and deletion key events while keeping it stripped from all other ones, as before.Please Check If the PR Fulfills these Requirements
go generate ./...)