Fix patch commands when git config has color=always#5405
Open
matthijskooijman wants to merge 1 commit intojesseduffield:masterfrom
Open
Fix patch commands when git config has color=always#5405matthijskooijman wants to merge 1 commit intojesseduffield:masterfrom
matthijskooijman wants to merge 1 commit intojesseduffield:masterfrom
Conversation
This is the same option as used by pkg.commands.git_commands.diff.GetDiff().
themavik
reviewed
Mar 23, 2026
themavik
left a comment
There was a problem hiding this comment.
Patch parsing assumes plain diff text; forcing --no-color beside --no-ext-diff stops ANSI escapes when color=always is set globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same option as used by pkg.commands.git_commands.diff.GetDiff().
This fixes some operations patch operation (tested with moving patch to another commit) with
git config set --global color.ui always(orcolor.diff always).Please check if the PR fulfills these requirements
go generate ./...) <-- N/A