Add NameLinkRenderer for clickable popover and update column types#1671
Merged
Add NameLinkRenderer for clickable popover and update column types#1671
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the UI data table’s Salesforce record navigation by adding a dedicated renderer for Name fields that opens the existing record-lookup popover (similar to the current Id link behavior), and updates column type resolution to automatically apply that renderer where appropriate.
Changes:
- Add
displayValue?: ReactNodesupport toRecordLookupPopoverso the trigger can show custom content (e.g., Name text instead of Id). - Introduce
NameLinkRendererand a newsalesforceNamecolumn type. - Update query-result column typing logic to auto-detect Name/relationship Name columns and render them as record popovers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/ui/src/lib/widgets/RecordLookupPopover.tsx | Adds displayValue to customize the popover trigger content. |
| libs/ui/src/lib/data-table/data-table-utils.tsx | Adds salesforceName type mapping + logic to promote Name columns to the new renderer. |
| libs/ui/src/lib/data-table/data-table-types.ts | Extends ColumnType union with salesforceName. |
| libs/ui/src/lib/data-table/DataTableRenderers.tsx | Implements NameLinkRenderer to show Name text while linking to record popover. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…date column type handling
paustint
force-pushed
the
feat/show-name-as-record-popover
branch
from
a83a93e to
43c8c83
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the data table by introducing a new renderer for Salesforce Name fields, making them clickable and providing a record-lookup popover similar to the existing Id link behavior. It also updates the column type logic to automatically detect and apply this renderer to appropriate fields, and improves the flexibility of the
RecordLookupPopovercomponent to support custom display values.