Conversation
There was a problem hiding this comment.
Pull request overview
Pins basic-ftp to a specific version to avoid compatibility issues in the dependency tree (currently pulled in via tooling dependencies).
Changes:
- Adds a
resolutionsentry inpackage.jsonto forcebasic-ftp@5.2.1. - Introduces a new
yarn.lockwithbasic-ftp@5.2.1resolved.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds a resolutions pin for basic-ftp to 5.2.1. |
| yarn.lock | Adds a Yarn lockfile reflecting basic-ftp@5.2.1 in the resolved tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "import": "./dist/esm/index.mjs" | ||
| } | ||
| }, | ||
| "resolutions": { |
There was a problem hiding this comment.
resolutions is a Yarn feature and won’t be applied by npm ci (the repo’s CI and existing package-lock.json indicate npm is the intended package manager). If the goal is to pin basic-ftp for npm installs, use the npm overrides field instead and regenerate package-lock.json so it actually resolves to 5.2.1.
Suggested change
| "resolutions": { | |
| "overrides": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the resolutions to ensure compatibility by pinning the basic-ftp package to version 5.2.1.