fix-exclusions-ignored-with-build-flag-for-dl-cmd#3335
Open
reshmifrog wants to merge 2 commits intojfrog:masterfrom
Open
fix-exclusions-ignored-with-build-flag-for-dl-cmd#3335reshmifrog wants to merge 2 commits intojfrog:masterfrom
reshmifrog wants to merge 2 commits intojfrog:masterfrom
Conversation
reshmifrog
added
bug
reshmifrog
added
safe to test
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....problem: When using the jf rt download command with the --build flag to download artifacts associated with a specific build, the --exclusions flag is ignored. Files matching the exclusion pattern are still downloaded.
soltuion: When using the --build flag, the dl cmd was calling createAqlBodyForBuildArtifacts() which only included build name/number filters in the AQL query, completely ignoring --exclusions param. The fix adds new functions that properly include exclusion patterns into the AQL query using buildExcludeQueryPart(), ensuring files matching exclusion patterns are filtered out.