fix reference token privilege escalation#3410
Open
reshmifrog wants to merge 1 commit intojfrog:masterfrom
Open
fix reference token privilege escalation#3410reshmifrog wants to merge 1 commit intojfrog:masterfrom
reshmifrog wants to merge 1 commit intojfrog:masterfrom
Conversation
reshmifrog
added
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Problem: When a reference token with restricted scope (e.g., Viewer) is used as --password in jf c add, the CLI's automatic token refresh creates a new token with scope=member-of-groups:*, escalating to the user's full permissions.
Solution: The fix auto-detects reference tokens by their stable base64 prefix (cmVmdGtuOj = reftkn:) and disables the token refresh mechanism, preserving the token's restricted scope.