Skip to content

Replace copied mjson with a standard library that is already provided by runtimes - org.eclipse.parsson:parsson; resolve #288#294

Merged
rhusar merged 1 commit intojgroups-extras:mainfrom
rhusar:288-parsson
Apr 2, 2026
Merged

Replace copied mjson with a standard library that is already provided by runtimes - org.eclipse.parsson:parsson; resolve #288#294
rhusar merged 1 commit intojgroups-extras:mainfrom
rhusar:288-parsson

Conversation

@rhusar
Copy link
Copy Markdown
Member

@rhusar rhusar commented Mar 25, 2026

No description provided.

@rhusar rhusar marked this pull request as ready for review April 1, 2026 06:28
@rhusar
Copy link
Copy Markdown
Member Author

rhusar commented Apr 1, 2026

@davido Any chance you would be able to review this?

@davido
Copy link
Copy Markdown

davido commented Apr 1, 2026

I’m not a committer on this project, so I can’t formally review or approve this change.

While migrating one of our Gerrit plugins to Bazel Modules, that depends on jgroups and jgroups-kubernetes I was tracking the dependencies that get shaded into the high-availability plugin. During that process, I noticed that some unrelated artifacts are being shaded but are not declared in the corresponding pom.xml.

See this change:

https://gerrit-review.googlesource.com/c/plugins/high-availability/+/561581/6/high-availability_third_party_runtime_jars.allowlist.txt

@rhusar
Copy link
Copy Markdown
Member Author

rhusar commented Apr 1, 2026

@davido This is OSS so you can review anything on GH :-) But yes, the review doesn't show as green check mark but only grey one.

Anyway, this was missing try-with-resources blocks in the Json.createReader(..) fixed now.

@rhusar rhusar requested a review from pferraro April 1, 2026 11:08
@rhusar
Copy link
Copy Markdown
Member Author

rhusar commented Apr 1, 2026

I would appreciate if you could review @pferraro as this is the last change required for the release so we can include this in WF 40 Beta.

… by runtimes - org.eclipse.parsson:parsson; resolve jgroups-extras#288

Signed-off-by: Radoslav Husar <radosoft@gmail.com>
@rhusar
Copy link
Copy Markdown
Member Author

rhusar commented Apr 2, 2026

Thanks @ehsavoie for the review MUCH appreciated!

The feedback about code style discussed, I will fix in a subsequent PR.

@rhusar rhusar merged commit 1d43293 into jgroups-extras:main Apr 2, 2026
9 checks passed
@rhusar rhusar deleted the 288-parsson branch April 2, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants