Bugfix: normalize nested hash keys with multipart data#804
Open
michaelrigart wants to merge 2 commits intojnunemaker:mainfrom
Open
Bugfix: normalize nested hash keys with multipart data#804michaelrigart wants to merge 2 commits intojnunemaker:mainfrom
michaelrigart wants to merge 2 commits intojnunemaker:mainfrom
Conversation
Signed-off-by: Michaël Rigart <michael@netronix.be>
Signed-off-by: Michaël Rigart <michael@netronix.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using HTTParty, I encountered a bug already mentioned in #757 .
It seems that normalizing the payload hash for multipart/form-data was not going as expected when the payload contained nested hashes and/or arrays.
The recursion inside the
normalize_keysmethod was not returning the proper result.This PR should fix this.