fix multivalued param dict handling in to_url, fix oauth_body_hash sending for GET requests#95
Open
tylerwilliams wants to merge 3 commits intojoestump:masterfrom
Open
fix multivalued param dict handling in to_url, fix oauth_body_hash sending for GET requests#95tylerwilliams wants to merge 3 commits intojoestump:masterfrom
tylerwilliams wants to merge 3 commits intojoestump:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches fix multivalued param handling for the case when you pass a dictionary with iterable values into a request and then call to_url. Previously this would encode the iterable value as a single string instead of encoding each value separately.
This also fixes the library to not send the "oauth_body_hash" parameter on GET or HEAD requests, as defined in the spec.