First commit. Wanted to commit the passing minimum of 7/10 before tak…#51
Open
IvanCastillo1986 wants to merge 3 commits intojoinpursuit:masterfrom
Open
First commit. Wanted to commit the passing minimum of 7/10 before tak…#51IvanCastillo1986 wants to merge 3 commits intojoinpursuit:masterfrom
IvanCastillo1986 wants to merge 3 commits intojoinpursuit:masterfrom
Conversation
| // will access the property values with arr.country | ||
| // | ||
| function getCountriesSortedByPopulation(arr) { | ||
| let newObj = {} |
There was a problem hiding this comment.
This function should return an array, not an object.
| function getCountriesSortedByPopulation(arr) { | ||
| let newObj = {} | ||
| for (let element in arr) { | ||
| newObj[element] = arr[element] |
There was a problem hiding this comment.
Consider what 'element' is, which information you need from the element, and which array method allows you to add data into the array you are going to return.
…sort, as well as accessing object elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing a break. Haven't passed all problems because I'm having trouble with some (such as disemvowel) and fighting the urge to look back at labs