Stringify for nums bigger than max safe integer#1646
Merged
josdejong merged 12 commits intojosdejong:developfrom Mar 26, 2025
Merged
Stringify for nums bigger than max safe integer#1646josdejong merged 12 commits intojosdejong:developfrom
josdejong merged 12 commits intojosdejong:developfrom
Conversation
josdejong
requested changes
Mar 12, 2025
Owner
josdejong
left a comment
josdejong
left a comment
There was a problem hiding this comment.
Thanks Pavel, I think it makes sense to parse a bigint into a string rather than a number which loses digits.
I made a few inline comments, can you have a look at those?
This reverts commit a639d83.
pawfrolow
changed the title
josdejong
reviewed
Mar 26, 2025
Owner
josdejong
left a comment
josdejong
left a comment
There was a problem hiding this comment.
Thanks for the updates Pavel, this looks good indeed! One small remark left, can you have a look?
josdejong
approved these changes
Mar 26, 2025
Owner
josdejong
left a comment
josdejong
left a comment
There was a problem hiding this comment.
Nice! I like how this PR turned out :)
Contributor
Author
|
Hi, @josdejong can you tell if there will be a new version with these changes? I also saw a small typo in the history file on line 8, there is a different nickname there :) |
josdejong
added a commit
that referenced
this pull request
Mar 28, 2025
Owner
|
Ah, sorry about that, I've fixed it via d56659a. I've just published |
Contributor
Author
|
Thanks a lot, great news! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've made fixes for two problems, discussed here #1259
1: Trying to paste big number like
7405242042266046865, that incorectly converts it to number, because it bigger that max safe integer.Before: https://github.com/user-attachments/assets/7869e787-c2da-4d1c-ac20-0e7243720148
After: https://github.com/user-attachments/assets/be9029f3-b726-4eb5-8c52-3e9bf4cfd798