bugfix: error color and number color

[reatang]

No description provided.

[josdejong]

Since all colors are using HEX code, it maybe good for consistency to also enter the color for numbers as HEX (#ee422e)

[reatang]

I borrowed the ace editor the color of the number.

[josdejong]

What is the reason that you changed the colors for numbers from red to blue? (I would prefer to keep the red color)

[reatang]

red just like Error 😂

[josdejong]

Thanks for your PR @reatang .

Currently the variable $jse-number is used for coloring numbers as well as coloring error text. It's a good idea to separate this. I think though we should create a new $jse-number variable with the same color code as $jse-number (red), and rename the current $jse-error to $jse-error-background, since that's how it is used right now. Does that make sense?

[reatang]

jse-error-background sounds like background-color rather than text-color.

[josdejong]

jse-error-background sounds like background-color rather than text-color.

That's correct: $jse-number was actually used only at one place for a background color, see _editor.scss. Therefore I think it makes sense to rename it. So:

1. rename

   $jse-error: #ee2e2e70 !default;

   to

   $jse-error-background: #ee2e2e70 !default;

2. create a new $jse-error: #ee2e2e !default;
3. Change the usages of $jse-number to $jse-error where applicable.

What do you think?