fix: wrap success return into try catch to avoid server side fatal error#44
Open
fginioux-golding wants to merge 1 commit intojoshkatz:masterfrom
Open
fix: wrap success return into try catch to avoid server side fatal error#44fginioux-golding wants to merge 1 commit intojoshkatz:masterfrom
fginioux-golding wants to merge 1 commit intojoshkatz:masterfrom
Conversation
When we are running the script and the R code throw an error the close callback is called with non parsable body and crash the node js application. To "gracefully" handle the error the proposition is to wrap the code into a try/catch and return the error instead of the body ;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are running the script and the R code throw an error the close callback is called with non parsable body and crash the node js application.
To "gracefully" handle the error the proposition is to wrap the code into a try/catch and return the error instead of the body ;