Fix for issue 'unexpected end of input' error in call function by JSON.parse#6
Merged
joshkatz merged 1 commit intojoshkatz:masterfrom Feb 12, 2018
Merged
Conversation
…arse'd causing error Concat data as chunks, callback on ‘close’ instead
prasad83
added a commit
to prasad83/r-script
that referenced
this pull request
Mar 15, 2017
When stderr and stdout gets data callback function get invoked twice. Devised following fix along with joshkatz#6
|
This is an important bug fix that should be accepted as it resolves an issue with async calls |
|
Async is very broken without this fix. I'm currently using payousefi's fork in production code. @joshkatz please merge this. |
|
🙌🏼 |
|
Unfortunately, this causes an a fatal error when R encounters an exception: body === "" as nothing is in stdout (it all goes to stderr) I think this can be fixed by #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced in issue #5