You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From JRuby 1.7.5
When I type arrow keys, 潯, 潼, 澑 and 潭 are inputed.
From JRuby 9.1.3.0
When I type arrow keys, a cursor doesn't move.
Causes
I found the following two causes.
First cause is JLine bug which was fixed in JLine 2.12. So we need to update JLine version.
(Currently JLine is updated in master branch of jruby/jruby, but it has not been released.)
Second cause is an argument of ConsoleReader constructor.
Related commit is 36c4315.
I can't understand why I can't use arrow keys.
But, it looks good when I changed InputStream to FileInputStream which is default of ConsoleReader constructor.
not sure about these changes ... yet 36c4315 seems reasonable // cc @headius
thus maybe we shall rather add some 'clever' detection if JRuby in/out == Java in/out
(Currently JLine is updated in master branch of jruby/jruby, but it has not been released.)
thus maybe we shall rather add some 'clever' detection if JRuby in/out == Java in/out
I think so too. But, it is difficult for me to fix in/out so I gave up and created this PR... sorry.
I hope this PR is merged if the clever way is difficult or needed long time or many resources for jruby developers. (because arrow keys are disabled on Windows jirb.)
However, I think this PR is not so good, so please close this PR if you think this PR should not be merged.
we shall work-around pushing to RGs ... in the mean time could you check how 1.3.7 is working for you?
Thank you. I didn't know this. I'll use when new JRuby or new jruby-readline which fixes this issue is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I can't use arrow keys on Windows jirb.
Versions which this issue occurs
From JRuby 1.7.5
When I type arrow keys,
潯,潼,澑and潭are inputed.From JRuby 9.1.3.0
When I type arrow keys, a cursor doesn't move.
Causes
I found the following two causes.
First cause is JLine bug which was fixed in JLine 2.12. So we need to update JLine version.
(Currently JLine is updated in master branch of
jruby/jruby, but it has not been released.)Second cause is an argument of ConsoleReader constructor.
Related commit is 36c4315.
I can't understand why I can't use arrow keys.
But, it looks good when I changed InputStream to FileInputStream which is default of ConsoleReader constructor.