Add $event as a second argument of handleDayClick#120
Open
maroun-baydoun wants to merge 1 commit intojsmodules:masterfrom
maroun-baydoun:on-day-click-event
Open
Add $event as a second argument of handleDayClick#120maroun-baydoun wants to merge 1 commit intojsmodules:masterfrom maroun-baydoun:on-day-click-event
maroun-baydoun wants to merge 1 commit intojsmodules:masterfrom
maroun-baydoun:on-day-click-event
Conversation
Author
|
The change introduced in #84 is causing the unit tests to fail. cc @fbertone @gavinbarron |
|
Hey! First of all, I think this is an excellent item. I appreciate the effort you guys have been putting here @maroun-baydoun @bradberger I hope you had a chance to release this one soon! :) 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes merge conflicts and parameter order from #40