Skip to content

Bug fix (Security Vulnerability)#2235

Merged
Utkarsh-123github merged 4 commits intojson-schema-org:mainfrom
Adityakk9031:#2227
Feb 25, 2026
Merged

Bug fix (Security Vulnerability)#2235
Utkarsh-123github merged 4 commits intojson-schema-org:mainfrom
Adityakk9031:#2227

Conversation

@Adityakk9031
Copy link
Copy Markdown
Contributor

@Adityakk9031 Adityakk9031 commented Feb 13, 2026

What kind of change does this PR introduce?

Bug fix – security hardening for external links by ensuring safe usage of target="_blank" with rel="noopener noreferrer" in tooling components.

Issue Number

Closes #2227

Screenshots / Videos

N/A – this is a code-level security fix with no visual changes expected.

Summary

This PR addresses the security vulnerability described in #2227 by adding rel="noopener noreferrer" to all external links in ToolingTable.tsx and ToolingDetailModal.tsx. It also corrects incorrect usages of target="blank" to the standard target="_blank" so that external links open in a new tab while following security best practices.

Changes

  • Added rel="noopener noreferrer" to external <a> tags rendered in ToolingTable.tsx.
  • Added rel="noopener noreferrer" to external <a> tags rendered in ToolingDetailModal.tsx.
  • Replaced all occurrences of target="blank" with the correct target="_blank" value on external links.

Does this PR introduce a breaking change?

No.

Documentation Updates

N/A.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@github-actions
Copy link
Copy Markdown

Hi @Adityakk9031! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description, completed checklist items

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@Adityakk9031
Copy link
Copy Markdown
Contributor Author

Adityakk9031 commented Feb 13, 2026

ok i will fix the error later tomorrow

@github-actions
Copy link
Copy Markdown

Hi @Adityakk9031! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description, completed checklist items

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 14, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 9c808e6

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e242d60) to head (9c808e6).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          660       663    +3     
  Branches       202       205    +3     
=========================================
+ Hits           660       663    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Hi @Adityakk9031! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: completed checklist items

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@Adityakk9031
Copy link
Copy Markdown
Contributor Author

@jagpreetrahi hey please have a look

Comment thread pages/tools/components/ToolingTable.tsx
@github-project-automation github-project-automation Bot moved this from Ready to review to Changes requested in PR - Triage Group Feb 19, 2026
@Adityakk9031
Copy link
Copy Markdown
Contributor Author

Hi @Utkarsh-123github, thanks for catching that!

In my previous commit, I accidentally removed the {bowtieData ? ... : } ternary logic in the mobile table section and replaced it with just the tag. This would have broken the fallback — tools without Bowtie data would render a broken link instead of the info icon.

I've fixed this in my latest commit. The changes are now minimal and purely security-focused:

Fixed target='blank' → target='_blank' (typo in original code)
Added rel='noopener noreferrer' to all external links
No structural or behavioral changes — the ternary fallback with InfoIcon is fully preserved
Could you please re-review? Thanks!

Copy link
Copy Markdown
Collaborator

@jagpreetrahi jagpreetrahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread pages/tools/components/ToolingTable.tsx Outdated
@Adityakk9031
Copy link
Copy Markdown
Contributor Author

@jagpreetrahi please merge this pr and this one #2236

@Utkarsh-123github
Copy link
Copy Markdown
Member

LGTM🚀
Thanks @Adityakk9031 for your efforts and contribution!

@Utkarsh-123github Utkarsh-123github merged commit 3c2522e into json-schema-org:main Feb 25, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Changes requested to Done in PR - Triage Group Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: External link hardening needed: rel="noopener noreferrer" absent

3 participants