fix: type issue where barrel exported functions could not be imported without a type error#160
Open
kylemcd wants to merge 1 commit intojsonnext:mainfrom
Open
fix: type issue where barrel exported functions could not be imported without a type error#160kylemcd wants to merge 1 commit intojsonnext:mainfrom
kylemcd wants to merge 1 commit intojsonnext:mainfrom
Conversation
… without a type error
🦋 Changeset detectedLatest commit: 8ef8325 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for codemirror-json-schema ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
@acao Could I get a review on this when you get a chance? Should be an easy merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing certain functions, for example
stateExtensions, would result in a type error:This issue seemed to effect any export from
./src/index.tsthat was barrel exported. This PR updates any barrel exported values within./src/index.tsto be named exports instead.This fixes the type issue:
