Add the ability to download artifacts automatically based on a regular expression#15
Open
AndreRenaud wants to merge 2 commits intojszwedko:masterfrom
Open
Add the ability to download artifacts automatically based on a regular expression#15AndreRenaud wants to merge 2 commits intojszwedko:masterfrom
AndreRenaud wants to merge 2 commits intojszwedko:masterfrom
Conversation
jszwedko
requested changes
May 12, 2018
Owner
jszwedko
left a comment
jszwedko
left a comment
There was a problem hiding this comment.
Thanks @AndreRenaud !
In principle, I can see how this would be useful, but what do you think of moving it to a separate subcommand, download-artifacts, that would be able to fetch based on the build and node or the build and path in addition to the regex.
| } | ||
|
|
||
| baseURL, err := url.Parse(c.String("host") + "/api/v1/") | ||
| baseURL, err := url.Parse(c.String("host") + "/api/v1.1/") |
Owner
There was a problem hiding this comment.
Did you mean to include this change? There is a PR over on go-circleci to switch or add support for the v1.1 API, but just switching the path causes 404s for many endpoints as the v1.1 API requires you to prefix the path with /github or /bitbucket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.