-
Notifications
You must be signed in to change notification settings - Fork 98
Add LDLFactorizations.jl as a package extension #2933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I don't understand how the default fallback is covered. I need to investigate more. It must be getting hit by a test before we load LDLFactorizations, but that seems flakey. I need to add an explicit test. |
|
Another thing to consider is that this does add a dependency to MOI with respect to compat bounds. But I think we're okay to take it on. cc @amontoison |
|
Maybe we should ask for a 1.0 tag on LDLFactorizations? |
|
Did you try the |
|
It doesn't support zero pivots: julia> import SparseArrays
julia> A = [1.0 1.0; 1.0 1.0]
2×2 Matrix{Float64}:
1.0 1.0
1.0 1.0
julia> Q = SparseArrays.sparse(A);
julia> LinearAlgebra.ldlt(Q)
ERROR: ZeroPivotException: factorization encountered one or more zero pivots. Consider switching to a pivoted LU factorization.
Stacktrace: |
|
It depends what you want to achieve at the end but why not calling again |
|
Given |
Closes #1971
Closes #2931