Fix deletion of constrained variables for CachingOptimizer#905
Merged
Fix deletion of constrained variables for CachingOptimizer#905
Conversation
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
==========================================
+ Coverage 95.12% 95.15% +0.02%
==========================================
Files 81 81
Lines 8592 8662 +70
==========================================
+ Hits 8173 8242 +69
- Misses 419 420 +1
Continue to review full report at Codecov.
|
odow
approved these changes
Sep 28, 2019
| @test !MOI.is_valid(model, cv) | ||
| v, cv = MOI.add_constrained_variables(model, MOI.SecondOrderCone(3)) | ||
| @test MOI.get(model, MOI.NumberOfVariables()) == 3 | ||
| @test_throws MOI.DeleteNotAllowed MOI.delete(model, v[1]) |
Member
There was a problem hiding this comment.
Hmmm.... I hadn't thought of this case. I guess it's reasonable.
Member
Author
There was a problem hiding this comment.
Passing existing tests with bridged variables put a lot of stress on the deletion API so as part of adding the variable bridges, we clarified what should be done in these corner cases. The relevant PR is #793
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To delete constrained variables, you need to delete the whole vector of variables at once if the set dimension cannot change like
MOI.SecondOrderCone. For this reason, it is important forCachingOptimizerto implement the deletion of vector of variables instead of relying on the fallback functions which deletes variable one by one otherwise you get the error: