Support configuring urlPropsIgnore via appdef app settings#1602
Draft
Support configuring urlPropsIgnore via appdef app settings#1602
Conversation
Co-authored-by: jumpinjackie <563860+jumpinjackie@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support setting urlPropsIgnore from app settings
Support configuring urlPropsIgnore via appdef app settings
Mar 11, 2026
Owner
|
@copilot Integrate latest changes from master and revalidate your current work |
Contributor
Author
Done. Merged master into the branch (commit d58ad2a) — no conflicts in the changed files. All 656 tests pass (93 test files, including the 92 test files from master and the new Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlPropsIgnorecould only be set via viewer mount options (IAppProps.urlPropsIgnore), requiring HTML template modification. This adds support for configuring it via an app setting in the loaded Application Definition — the established pattern for avoiding template changes.Changes
src/containers/app.tsxAPP_SETTING_URL_PROPS_IGNORE = "urlPropsIgnore"constant for the app setting keygetEffectiveUrlPropsIgnore(propIgnore, settingsValue)helper that merges the prop value with a comma-separated app settings valueuseCustomAppSettings()call inAppto subscribe to Redux app settings stateprops.appSettings["urlPropsIgnore"])configuredAppSettings["urlPropsIgnore"]) toupdateUrl()andgetEffectiveUrlPropsIgnoreis re-evaluated when appdef settings land in Redux statetest/containers/app.spec.ts(new)getEffectiveUrlPropsIgnorecovering merging, trimming, empty filtering, and undefined inputsUsage
In an appdef
ViewerSettings(no HTML template change needed):Appdef-provided values are merged with any
urlPropsIgnoreprop already specified at mount time, so the two approaches compose rather than conflict.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
storybook.js.org/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/mapguide-react-layout/mapguide-react-layout/node_modules/.bin/storybook build -c .storybook(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.