Open
Conversation
added 2 commits
February 7, 2018 13:47
Collaborator
|
Why a lot of files shown as changed from 0644 to 0755? Did you check this PR by yourself? |
aprokopenko
requested changes
Jun 28, 2018
framework/Theme.php
Outdated
| use JustCoded\WP\Framework\Supports\Just_Tinymce; | ||
| use JustCoded\WP\Framework\Web\Template_Hierarchy; | ||
| use JustCoded\WP\Framework\Supports\Just_Load_More; | ||
| use JustCoded\WP\Framework\Supports\Socials_Feed; |
Collaborator
There was a problem hiding this comment.
this one is not used here. please remove
framework/Supports/Socials_Feed.php
Outdated
| } | ||
|
|
||
| protected function is_exists( $post_title ) { | ||
| return get_page_by_title( wp_strip_all_tags( $post_title ), OBJECT, self::POST_TYPE ); |
Collaborator
There was a problem hiding this comment.
I think it's better to search by slug, not by name
framework/Supports/Socials_Feed.php
Outdated
| 'post_date' => date( 'Y-m-d H:i:s', $timestamp ), | ||
| 'post_name' => 'twitter_post_' . $twitter_post->id, | ||
| 'post_type' => self::POST_TYPE, | ||
| 'post_status' => 'draft', |
Collaborator
There was a problem hiding this comment.
why it's "draft" (same for all socials)?
| 'public' => true, | ||
| 'hierarchical' => true, | ||
| 'taxonomies' => array(), | ||
| ) ); |
Collaborator
There was a problem hiding this comment.
I think it should be hidden from admin interface. Don't know why you need "hierarchical" here?
And I think it will be useful to make visible in admin or not - a class option, so it can be configured easily in a theme
| 'name' => 'Socials Category', | ||
| ), | ||
| 'public' => true, | ||
| 'hierarchical' => false, |
Collaborator
There was a problem hiding this comment.
manageable UI should not be visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.