Several CLI improvements#15
Open
joshkel wants to merge 1 commit intojvilk:masterfrom
joshkel:cli-improvements
Open
Several CLI improvements#15joshkel wants to merge 1 commit intojvilk:masterfrom joshkel:cli-improvements
joshkel wants to merge 1 commit intojvilk:masterfrom
joshkel:cli-improvements
Conversation
Shorten the help text; previously, yargs wasn't leaving a space between a parameter's help text and its type (`classes[string]`). Fix a misspelling in help text. Show a warning if neither -i nor -p is specified, to make the command a bit less confusing for those who don't read the help. Allow providing multiple filenames as input. (See #10.) Allow input filenames to consist of a single JSON sample object as well as an array of JSON sample objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a bit of a grab bag: I don't know if you'll want all of these changes as is or not.
Part of this is similar to #11 (which I hadn't seen before I put this together); one difference is that this accepts passing a single file containing JSON sample object or multiple files containing JSON arrays of sample objects, while #11 assumes that a single parameter means a JSON array of sample objects and multiple parameters mean multiple files containing JSON sample objects.
Specific changes:
Shorten the help text; previously, yargs wasn't leaving a space between a parameter's help text and its type (
classes[string]).Fix a misspelling in help text.
Show a warning if neither -i nor -p is specified, to make the command a bit less confusing for those who don't read the help.
Allow providing multiple filenames as input. (See #10.)
Allow input filenames to consist of a single JSON sample object as well as an array of JSON sample objects.