Open
Conversation
… Add sample folder with demo. Add test cases. Ensure documenting how to get dapr up and running + add required components Signed-off-by: Casper Nielsen <casper@diagrid.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Python integration package (kagent-dapr) to expose Dapr Agents DurableAgent via KAgent’s A2A protocol, plus a Kubernetes-ready sample (manifests + Dockerfile) demonstrating durable execution backed by Dapr Workflow + Redis.
Changes:
- Introduces
python/packages/kagent-daprwith a FastAPI A2A app builder and aDaprDurableAgentExecutor, plus unit tests. - Adds a full Dapr sample under
python/samples/dapr/(agent code, agent card, k8s manifests, components, Dockerfile, docs). - Updates the Python uv workspace configuration and Makefile to accommodate/build the new sample.
Reviewed changes
Copilot reviewed 24 out of 31 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| python/samples/dapr/dapr-agent/pyproject.toml | Sample project definition and local path sources for kagent packages |
| python/samples/dapr/dapr-agent/agent.py | Minimal DurableAgent + KAgentApp server entrypoint |
| python/samples/dapr/dapr-agent/agent-card.json | Agent card used by the A2A server |
| python/samples/dapr/components/redis.yaml | Redis deployment/service/secret for Dapr components |
| python/samples/dapr/components/agent-*.yaml | Dapr state/pubsub components for workflow/runtime/registry/memory |
| python/samples/dapr/agent.yaml | KAgent Agent CR for BYO deployment with Dapr sidecar injection |
| python/samples/dapr/README.md | Setup and usage documentation for the sample |
| python/samples/dapr/Dockerfile | Container image build for the Dapr sample agent |
| python/pyproject.toml | uv workspace membership/exclusions updated for Dapr-related dependency conflicts |
| python/packages/kagent-dapr/src/kagent/dapr/_durable.py | Durable workflow-backed A2A executor implementation |
| python/packages/kagent-dapr/src/kagent/dapr/_a2a.py | FastAPI app builder wiring A2A server + durable executor |
| python/packages/kagent-dapr/tests/test_*.py | Unit tests for durable executor and app build behavior |
| python/packages/kagent-core/src/kagent/core/tracing/_span_processor.py | Typing update for span attribute setter |
| python/packages/kagent-core/src/kagent/core/tracing/init.py | Re-exports span processor helpers in tracing package |
| python/Makefile | Adds dapr-agent-sample docker build target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
python/packages/kagent-core/src/kagent/core/tracing/_span_processor.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Casper Nielsen <whopsec@protonmail.com>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Casper Nielsen <whopsec@protonmail.com>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
…essor.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Casper Nielsen <whopsec@protonmail.com>
…d from uv workspace Signed-off-by: Casper Nielsen <casper@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Dapr Agents as a KAgent with sample setup.
The Agent is using Dapr Agents DurableAgent to provide durable and reliable execution.
Note: I had to exclude the
kagent-daprfrom the uv workspace as thegoogle-adkdep has a transient dependency onopentelemetry-sdk <1.39.0anddapr-agentsrequiresopentelemetry-sdk >=1.39.