Open
Conversation
s373r
reviewed
Jan 15, 2026
|
|
||
| pub fn extend_graphql_request( | ||
| request: async_graphql::Request, | ||
| catalog: &Catalog, |
s373r
reviewed
Jan 15, 2026
Comment on lines
+20
to
+22
| pub struct GraphqlRequestContext { | ||
| pub extend_request: fn(async_graphql::Request, &Catalog) -> async_graphql::Request, | ||
| } |
Member
There was a problem hiding this comment.
Q: Can we try to avoid this dill component by currying graphql_handler() w/ some before request callback?
I mean that we call some sort of handler builder which will return the handler to us in the form of a function?
s373r
requested changes
Jan 15, 2026
Member
s373r
left a comment
s373r
left a comment
There was a problem hiding this comment.
Please use sku/molecule_phase_2 as the base branch -- we need this refactoring in the near future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1504
Checklist before requesting a review