Add possibility to run e2e tests with elasticsearch#1556
Open
rmn-boiko wants to merge 77 commits intosku/moleculefrom
Open
Add possibility to run e2e tests with elasticsearch#1556rmn-boiko wants to merge 77 commits intosku/moleculefrom
rmn-boiko wants to merge 77 commits intosku/moleculefrom
Conversation
* GQL: split Molecule into MoleculeV1 & MoleculeV2 * GQL: MoleculeMutV2 WIP * Move account_mut.rs to ./account_mut/ * GQL: Account quotas * test_search_accounts_by_name_pattern(): fix rebase collision * GQL: MoleculeDataRoomMut * GQL: MoleculeV2: announcements & whole file tweaks * GQL: MoleculeMutV2: announcements * GQL: MoleculeV2::activity() * Fixes after self review * AccountQuotasMut::set_user_level_quotas(): add doc string * Backported changes to make clippy a bit happier
* Tests: mark the current molecule tests as v1 * Modularize Molecule queries * Molecule: extract common things into common.rs * molecule/v2: create a dir * molecule/v1: create a dir * molecule_mut/: create a dir * molecule_project_v2.rs: extract * molecule_activity_event_v2.rs: extract * molecule_data_room_dataset_v2.rs: extract * molecule/: split rest entities * molecule_mut/: split rest entities * MoleculeV2::activity(): add "filters" arguments * MoleculeAnnouncementsDatasetV2::tail(): add "filters" argument * schema.gql: regenerate
* UpdateVersionFileUseCaseHelper: extract * MoleculeDataRoomMutV2::start_upload_file(): implement * QueryService::get_changelog_projection(): implement * QueryService::get_changelog_projection(): add "hint" options * MoleculeDataRoomMutV2: polished methods expect "finish_upload_file()" * MoleculeDataRoomMutV2::finish_upload_file_new_file() * MoleculeDataRoomFinishUploadFileV2 * MoleculeDataRoomMutV2::update_file_metadata(): a try to add the second step * MoleculeDataRoomMutV2::finish_upload_file_new_file_version() * clippy fixes * schema.gql: regenerate * Fix Molecule v1 tests * Working on Molecule v2 data room api * Molecule v2 API: implement basic data room operations * Migration fix * Inlined `UpdateVersionFileUseCaseHelper` within GQL utils, as we may not use `UploadService` in the "datasets" domain. + fixed MySQL migration * Try fixing ODF code generation flow * MoleculeDataRoomMutV2::finish_upload_file_new_file_version(): use UpdateCollectionEntriesUseCase * MoleculeDataRoomMutV2::finish_upload_file_new_file(): use UpdateCollectionEntriesUseCase * MoleculeDataRoomMutV2::move_entry(): use UpdateCollectionEntriesUseCase * MoleculeDataRoomMutV2::remove_entry(): use UpdateCollectionEntriesUseCase * MoleculeDataRoomMutV2::update_file_metadata(): implement * Schema regenerated * test_molecule_v2_data_room_operations(): use pretty_assertions::assert_eq * moveEntry test * removeEntry test * updateFileMetadata test * schema.gql: regenerate --------- Co-authored-by: Sergii Mikhtoniuk <mikhtoniuk@gmail.com> Co-authored-by: Sergei Zaychenko <zaychenko.sergei@gmail.com>
…1463) * Established Molecule domain & service crates. Extracted "View Molecule Projects" use case, and plugged into v1/v2 APIs * Extracted "Find Molecule project" use case * Extracted "Create Molecule project use case". Molecule dataset snapshots, as well as generic VersionedFile/Collection dataset snapshots are now a domain, not GQL concern. * Extracted `MoleculeProjectEntity` object to use instead of untyped JSON objects at domain level. GQL objects converted to [Object], replacing [SimpleObject], and keep entity. * Improved telemetry in new Molecule service layer * Sketched MoleculeProjectMessage outbox events. For now, sending "Created" message from the corresponding use case. * Review notes fixed
* UpdateCollectionEntriesUseCaseImpl::build_data_batches(): return note * MoleculeDatasetSnapshots::data_room_v2(): create alias internally * MoleculeDatasetSnapshots::projects(): create alias internally * MoleculeDatasetSnapshots::announcements(): create alias internally * StageDataResult: update doc strings * PushIngestOpts: fix a typo * MoleculeDatasetSnapshots::global_data_room_activity() * MoleculeProjectService -> MoleculeDatasetService * MoleculeDatasetService::get_global_data_room_activity_dataset() * MoleculeProjectV2::ipnft_token_id(): use U256 * MoleculeAppendDataRoomActivityUseCaseImpl * Tests stabilized * MoleculeDatasetSnapshots::global_data_room_activity(): update comment re LIST<BYTE_ARRAY item (STRING)>) * MoleculeDataRoomMutV2::finish_upload_file_new_file_version(): write data room activity * MoleculeDataRoomMutV2::finish_upload_file_new_file(): add maintainer permissions to molecule * DatasetHandleLoader: add AccessCheckedDatasetRef-related load() method * DatasetHandleLoader: add AccessCheckedDatasetRef-related load() method + ResolvedDataset * MoleculeVersionedFile::latest(): use data loader * MoleculeViewDataRoomActivitiesUseCaseImpl * MoleculeV2::activity() * MoleculeV2::activity() * test_molecule_v2_data_room_operations(): global activity checks (part) * MoleculeProjectV2::get_data_room_activity_events(): fixed, unit-tested * clippy fixes * test_internal_error(): simplify * OperationType::deserialize(): simplify * access_level: update todo * Add todos * Consts for snapshot names * Add global prefix
#1468) * Datasets domain use cases reorganized by folders * Extracted 'ViewCollectionEntriesUseCase' use case in datasets domain * Merge corrections * Extracted `FindCollectionEntryUseCase` * FindCollectionEntryUseCase => FindCollectionEntriesUseCase * More renaming cleanups * Listing structs: use EntityPageListing template. Introduced `CollectionPath` at datasets domain level. Domain's `ExtraDataFields` applied more systematically. * Extracted `ViewVersionedFileHistoryUseCase` * Extracted `FindVersionedFileVersionUseCase` use case * Simplified structures in `UpdateCollectionEntriesUseCase` * Cleanups in GQL adapters for collections and versioned files * Minor review
* Finish global data room activity * Correct project data room activities
* Add disable/enable project api * Fix clippy * Add comments * Fix review comments - Iter 1 * Refactor changelog entry duplication * Refactore: use GraphQLQueryRequest in tests * Add chain length asserts * Make chain search with alias parameter * Fix review comments * Fix tests * Update schema
…1472) * Molecule use cases need some folder structure too. Extracted use cases `MoleculeFindProjectDataRoomEntryUseCase` and `MoleculeViewProjectDataRoomEntriesUseCase`: those indirectly request project data rooms as a collection dataset, and map structures. A direct collection adapter talking to service layer of `kamu-datasets` (not to GQL!), with the extension seam for future federation (invoking collection entries from base GQL API remotly) * Got rid of manual DataFrame at GQL level when writing or updating file versions * `MoleculeDataRoomEntry`: simplified domain structure and GQL equivalent * Some intermediate cleanups after merge * First attempt to extract data room UPSERT use case * Upsert data room entry: returning new data room record * Extracted `MoleculeRemoveProjectDataRoomEntryUseCase` * Extracted `MoleculeMoveProjectDataRoomEntryUseCase` + aligned common parts with removals * Update metadata uses data-room level upsert use case * Telemetry cleanup * Naming cleanups * First sketch of data room outbox message: sending for move and remove * Split upsert data room entry on create and update UC, as they need to produce different outbox output * Propagating source event time for collection entry operations * Propagating system time from versioned file ingest properly * Got rid of extra ReBAC check at highest data room access point
* MoleculeDatasetService::get_global_announcements_dataset() * MoleculeCreateAnnouncementUseCase * MoleculeProjectMutV2::announcements() * format-utils crate * MoleculeAnnouncementsDatasetMutV2::create() * MoleculeViewGlobalDataRoomActivitiesUseCaseImpl: respect announcements * Molecule use cases: activity/ -> activities/ * Adaptation to the latest refactoring * MoleculeV2::activity() * MoleculeAnnouncements (project) * MoleculeProjectV2::activity(): update with announcements * MoleculeCreateAnnouncementUseCaseImpl: register * Tests fix * Tests fix [2] * Tests fix [3] * MoleculeProjectAnnouncementDataRecord: add a TODO * schema.gql: regenerate
* test_molecule_v2_announcements_operations(): checkpoint -- add 2 files * test_molecule_v2_announcements_operations(): checkpoint -- create empty announcement * test_molecule_v2_announcements_operations(): checkpoint -- Create an announcement with one attachment * test_molecule_v2_announcements_operations(): checkpoint -- Create an announcement with two attachments * test_molecule_v2_announcements_operations(): checkpoint -- Create an announcement with attachment DID that does not exist * test_molecule_v2_announcements_operations(): checkpoint -- Announcements are listed as expected * test_molecule_v2_announcements_operations(): finish * MoleculeAnnouncementEntry: system_time/event_time
* MoleculeEncryptionMetadata * schema.gql: regenerate * MoleculeDatasetSnapshots::versioned_file_v2(): remove todo * MoleculeEncryptionMetadata: extract to domain
…nPathV2` scalar (#1480) * DatasetNameGenerator * MoleculeDataRoomMutV2::build_new_file_dataset_alias(): use DatasetNameGenerator * CollectionPathV2 (domain) * CollectionPathV2 (domain): updates * CollectionPathV2 (GQL) * CollectionPathV2 (GQL): tests * schema.gql: regenerate * kamu-datasets: remove unused dep * Test fixes after resent changes * RUSTSEC-2025-0134
* ViewCollectionEntriesUseCase: support extra data filters * From<GetDataRoomCollectionEntriesFilters> for Option<kamu_datasets::ExtraDataFieldsFilter> * MoleculeDataRoomCollectionService::get_data_room_collection_entries(): add filters * MoleculeViewDataRoomEntriesUseCaseImpl: filters * MoleculeDataRoomProjection::entries(): filters * MoleculeDatasetSnapshots::global_announcements(): update SetInfo * utils::DataFrameExtraDataFieldsFilterApplier: extract * MoleculeAnnouncements::tail(): filters * GetDataRoomCollectionEntriesFilters -> GetMoleculeDataRoomCollectionEntriesFilters * A clearer separation of filter entities * MoleculeAnnouncements::tail(): filters * MoleculeProjectV2::get_data_room_activity_events(): filters * MoleculeProjectV2::get_data_room_activity_events(): filters [2] * MoleculeProjectV2::activity(): filters * MoleculeViewGlobalActivitiesUseCase: filters * schema.gql: regenerate * test_molecule_v2_activity(): start unlocking * test_molecule_v2_activity(): Activities are empty
…#1489) * Versioned files: sketched and plugged create/update use cases * Specialized use case for update file metadata. Integrated read file version use case, and simplified read model. * Minor: versioned file API moved out of data room file * Minor: avoid cloning file info for serde * Minor: unifying arguments of update/upload use cases * Clarified access checking in versioned file use cases * Isolated versioned file content access behind a service * Avoiding ResolvedDataset and similar in Molecule domain interface * MoleculeVersionedFile::asOf supported. Drafted MoleculeVersionedFile::matching (not public) - takes the versioned file version that exactly matches data room entry. MoleculeVersionedFile::latest is correctly not reusing denromalized data, as it's not guaranteed the data room entry is the latest one. * Revised schema optionals * Spelling * Enabled MoleculeVersionedFile::matching endpoint. Optimized MoleculeVersionedfile::latest endpoint, when data room entry is also the latest, using denormalized data. * Guiding comments
) * test_molecule_v2_activity(): Create a few versioned files * test_molecule_v2_activity(): Upload new file versions * test_molecule_v2_activity(): Link new file into the project data room -- not relevant for v2 * test_molecule_v2_activity(): Move a file (retract + append) * test_molecule_v2_activity(): Update a file (correction from-to) -- not relevant for v2 * test_molecule_v2_activity(): Create an announcement * test_molecule_v2_activity(): Upload a new file version * test_molecule_v2_activity(): Remove a file * test_molecule_v2_activity(): Check project activity events * test_molecule_v2_activity(): Create another project * test_molecule_v2_activity(): Create an announcement for the second project * test_molecule_v2_activity(): Check global activity events * test_molecule_v2_activity(): In-between activity asserts * test_gql_custom_molecule_v2: remove misleading clone() * test_molecule_v2_activity(): Filters without values * datafusion: register array functions * DataFrameExtraDataFieldsFilterApplier:: respect array columns * test_molecule_v2_activity(): Filters by tags: tag1 * test_molecule_v2_activity(): Filters by tags: [tag2] * test_molecule_v2_activity(): // Filters by tags: [tag2, tag1] * test_molecule_v2_activity(): Filters by categories: [test-category-1] * test_molecule_v2_activity(): Filters by categories: [test-category-2] * test_molecule_v2_activity(): Filters by categories: [test-category-2, test-category-1] * test_molecule_v2_activity(): Filters by access levels: [public] * test_molecule_v2_activity(): Filters by access levels: [holders] * test_molecule_v2_activity(): Filters by access levels: [public, holders] * test_molecule_v2_activity(): Filters combination: [test-tag2] AND [test-category-1] AND [holders] * test_molecule_v2_activity(): Project filters * test_molecule_v2_announcements_operations(): announcements filters * test_molecule_v2_data_room_operations(): announcements filters
…ouncements) * Extracted 'view project announcements' use case * Extracted "find project announcement" use case * Split Molecule dataset services * Moved most services from Molecule domain to services crate, broke all dependencies from API level * Minor cleanups * Sketched new approach of dataset accessor and used it to simplify announcements use cases for now * Same accessor approach applied to activities * Same accessor approach applied to projects dataset * Better reader/writer helpers for projects * Naming simplifications * Simplified announcements data model * Further model unifications: clear separation between changelog entry, changelog insertion record, payload record, and entity. Cleaned up event time / system time propagation in all Molecule write use cases. * Outbox events for announcements * Outbox event for activities * Activities: extracted view project activity use case, related structures cleanup * Minor correction
…ters within same logical group via OR operator
…Entry]` not `[DatasetID]` (#1541) * FindCollectionEntriesUseCase::execute_find_by_ref(): ref as a ref not slice * MoleculeFindDataRoomEntryUseCaseImpl: update error handling * MoleculeFindDataRoomEntryUseCase::execute_find_by_refs(): impl * MoleculeDataRoomCollectionServiceImpl::find_data_room_collection_entries_by_refs(): implement * MoleculeCreateAnnouncementUseCaseImpl::validate_attachments(): corrections * MoleculeAnnouncementPayloadRecord: fix typos * MoleculeAnnouncementEntry::attachments(): return file versioned files not refs * MoleculeAnnouncementEntry::attachments(): return dataroom entries not refs * MoleculeDataRoomCollectionServiceImpl::find_data_room_collection_entries_by_refs(): restrore refs order * test_molecule_v2_activity(): update * test_molecule_v2_announcements_operations(): update * test_molecule_v2_search(): update * Self-review * test_molecule_v2_activity_change_by_for_remove(): fix
* Add molecule per project access level filter * Add access level rule deduplication logic * Make ipnftUid required field for MoleculeAccessLevelRule * Reduce clones
* GQL: guards module breakdown * Molecule::v1 -- feature gate * FeatureEnabledGuard: tests * Self-review
…into sku/molecule_phase_2
* Renamed existing natural language service stuff
ElasticSearch first steps:
- followed footsepts of natural language search components
- makefile: ElasticSearch start, stop, and clean actions
- achieved connectivity to started ElasticSearch cluster
- achieved connectivity to self-launched child container service
- test GQL endpoint, routing cluster health info for now
- indexer: scaffold, no real indexing yet
- search service API: scaffold, no real implementation yet
Full text search:
- support framework for entity schemas registration (no versioning/migrations yet)
- ES: first client calls for index check, registration, documents counting
- feeding schemas for accounts and datasets from corresponding domains (very simplified fields now)
- entire process happens via plugin style, partiular domains register provider components that are accessed by template shared process
ElasticSearch code structure extended:
- separated low level operations in `ElasticSearchClient`: deals with engine connection building, sending queries in the right format, interpreting responses, and dealing with API errors
- `ElasticSearchIndexMappings` handles creation of index mappings for the given schema + hashing it's content, this will be a future place to apply complex column properties depending on configs
- `ElasticSearchVersionedEntityIndex` manages indexes for entities and aliases, auto-registers indcies, validates schema metadata, automatically detects drifts without version modification, automatically applies breaking or reindsable upgrades
- main repository code stays at very high level
Basic shape of full ElasticSearch index re-indexing + sketched simplest indexing procedure for Datasets
Indexing owner-id in datasets index (for filters)
ElasticSearch indexing added for Accounts
Indexing creation time for Accounts/Datasets
Indexing dataset documents similarly to natural language seach: added schema fields, description, keywords, and attachments
More realstic field roles: hierarchical identifiers (account name, dataset name, alias, schema field), prose (description, attachments), keywords (owner_id, keyword, dataset_kind) - with corresponding analyzers and properties for ElasticSearch
Added "Title" field role, which is in between Prose and Identifier, using for account's display names for now.
Identifier fields get inner-ngrams (3..6) and wider edge-ngrams (2..10).
Account life cycle events update ElasticSearch index:
- massaged events format a bit to satisfy new needs
- new outbox event handler for account search index updates
- reorganized account schema code to encapsulate 1 document operations, while indexer and update handler use it's helpers
- issuing bulk insert, update, delete operations in ES for account events
Dummy implementation in e2e tests (until a better solution is found, as containerized ES starts for over 20s per each command, and that's affected by acocunt/dataset lifecycle events)
Implemented updates to ElasticSearch for dataset-related events: lifecycle, reference update, parent account rename/delete.
Fixed account deletion handler in datasets domain, no ReBAC/dangling checks should be executed during system event handling.
Datasets schema: better incremental re-indexings for partial updates
Hotfix: improved detection of invalid intervals in case of breaking changes in the dataset, when expected tail is ahead of head
First sketching of a search function:
- simplest querying: query_string vs match_all, depending if non-empty query was received
- support specifying list of indexes vs defaulting to all schemas
- ES: sending search request, decoding response
- trivial GQL endpoint support
Naive pagination support (size/from).
Requesting source fields in multiple modes: None, All, Particular, Complex (include+exclude patterns)
Next ElasticSearch steps:
- Search schemas constants moved and published by domains, so that GQL can reference those fields.
- Support flexible sorting of search results: N criterias, by field or relevance score, configurable direction.
- Each schema now provides a field that can be used for universal alphabetial sorting ("title" alias)
Support basic search filters (keyword = value, keyword in {values}) and compound from those (and, or, not).
Added convenience macros to specify compound filters and for sort specifications.
Search highlights for textual fields: displays best fragments explaining why certain document's field matched the query
On-demand "explain" option: outputs low-level ElasticSearch scoring computation formula
* Sketched Molecule service crate + 4 Molecule search index schemas (projects, data room entries, announcements, activitty events)
* ES: support unprocessed objects field (stored, but not indexed or searched)
* Schema: using UnprocessedObject for activity body JSON
* Merged previous adapter into new sku/molecule/domain|services
* Automatic reindexing of Molecule projects in ElasticSearch
* Flakky hell on flow e2e fixed
* Reacting to MoleculeProjectMessageCreated, adding new ElasticSearch document
* Supporting boolean fields + added a generic banning feature for ES indices (filter is auto-attached to "read alias").
Fix: search should always be directed to "read alias", never to "writable index".
* Added Molecule project banning reaction in search: handling outbox "project disabled" and "project reenabled" messages and setting "is_banned" attribute
* Merge corrections
* Introduced `KamuBackgroundCatalog`: catalog wrapper without user account, to use for background lazy processes like on demand search indexer.
Generalized Molecule reindexing template algorithm: start from `KamuBackgroundCatalog`, attach Molecule org account as subject, initiate separate transaction, then run indexing on Molecule's account behalf.
Drafted data room entries reindexing. Relaxed compatibility requirements, so that v1 data room datasets don't crash when loaded.
* Forgotten fields in data rooms schema
* Bulk-based indexing for projects and data room entries
* Indexing speedup: loading entries from N projects in parallel
* Corrections in ES client: use single bulk update operation with encoded comands, so that heterogenous ops are possible in one bulk.
Simplified search context: we don't need account for now.
* Incremental indexing of data rooms.
* Lock correction
* Sketched global indexing of announcements
* Sketched announcements incremental indexing
* Sketched activity full indexing
* Sketched incremental indexing for activities
* Indexing code restructuring and simplification
* Added "activity_type" field to activity search schema
* Sketched filtering latest dataset room entries via ElasticSearch query
* "contentText" from versioned file entries is automatically attached to data room entry index in ElasticSearch
* Drafted listing latest view of global and project announcements via ElasticSearch
* Stabilized announcements filtering via ElasticSearch:
- sort objects fixed
- view global activities: fetching announcements via use case, to activate ElasticSearch as well
* Similar changes in projects schema
* Filtering global and project activities via ElasticSearch.
ElasticSearch: fixed bug in schema name resolution.
* Merge corrections
* Implemented Molecule's search use case via ElasticSearch.
+ Common module for all Molecule shared search schema declarations: field names and field definitions.
* Search corrections
* Backported ElasticSearch-focused changes from Molecule branch
* Deps correction
* Simplifying renames
* Unified account/dataset schemas to the style in Molecule branch
* Prototyped framework for integration tests with ElasticSearch involved:
- EsTestContext: main facility, lazily initializes reusable ES client
- a test proc-macro hiding the plumbing of the context
- each test receives a dill::Catalog prefilled with ES client, ES repository impl, with unique randomly generated index prefix
- a succesful test automatically cleans it's own indices, while a failing test keeps the indices available for inspection
- on first ES client initialization, the potentially abandoned test indices from previous sessions are discarded automatically
- written first couple tests for Accounts indexing
* Correct spelling of "Elasticsearch" brand name
* ElasticSearch test group on CI/CD
* More account indexing tests
* Initial test suite for datasets indexing.
Hardening es_client against async waiting issues: created index must be reachable, assigned alias must be reachable.
Makefile: automated cleaning of abandoned test artifacts from previous experiments. Not doing this in fixtures, as `cargo nextest run` creates races around it executing every test in separate process.
* Common searching harness + aligning dataset use case harness to be more pluggable
* Shared fixture for account use case tests + indexing tests.
Accounts indexing: testing predefined indexer
* Tests: predefined datasets indexing
* MT version of predefiend datasets indexing test
* MT version of incremental indexing
* Tests: renaming or deleting account affects index of it's datasets
* Udeps fixed
* Improvements and tests for detailed dataset content indexing (schema, setInfo, attachments).
Not indexing default vocabulary fields in schema, as those do not contribute to search relevance.
Indexing tests run with real outbox to maximize realism: forcing sync when necessary between test steps
* Added basic test suide for datasets searching: checking analyzers, filters, stemmers, ...
* Elasticsearch basically plugged into v2 Molecule tests, runs indexing, writes data, but is not yet queried
* Stabilized Molecule Elasticsearch filter/search tests.
Problem with E2E test persists for now
* Temp fix: e2e + elasticsearch
* Stabilized e2e vs integration test vs full manual indexing test with regards to catalogs
* Removed Postgres + Elasticsearch e2e combo
* Elasticsearch: abiility to setup, connect to, and test with a server using HTTPS/TLS
* Elasticsearch support for access level rules
* test_molecule_v2_activity_change_by_for_remove: left only SQlite version, our CI is not ready for elasticsearch+postgres combo
* Search indexer config:
- affects both QDrant and Elasticsearch
- support "clear_on_start" and dataset indexing filters in Elasticsearch
- support disabling incremental search index updates
* Feature flag: enable/disable Molecule APIs to read from projection in Elasticsearch
* ODF generated file fix
* More odf gen corrections
* More ODF codegen fix
* Schema regenerated
… S3, so use particular hash from outbox message
rmn-boiko
force-pushed
the
feat/e2e-elasticsearch-test-setup
branch
from
74c3199 to
21bf512
Compare
rmn-boiko
force-pushed
the
feat/e2e-elasticsearch-test-setup
branch
from
b648cd6 to
5d570af
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.