fix :handle mixed string and interger types in add()#231
Open
prsai0110 wants to merge 1 commit intokaran:masterfrom
Open
fix :handle mixed string and interger types in add()#231prsai0110 wants to merge 1 commit intokaran:masterfrom
prsai0110 wants to merge 1 commit intokaran:masterfrom
Conversation
Author
|
I found a bug in the add() function where it doesn’t properly handle mixed string and integer types. Steps to Reproduce
import simple_math
result = simple_math.add("5", 10)
print(result) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
simple_math.add() was not handling mixed types correctly and was concatenating values.
Solution
Added a type check to raise TypeError if arguments are not int or float.
Testing
Tested with both integer and mixed types — confirmed expected behavior.