Skip to content

Comments

fix(uptimekuma): fix critical bugs in pull mode and webhook handling#5641

Open
ART-R2D275 wants to merge 1 commit intokeephq:mainfrom
ART-R2D275:fix/uptimekuma-provider-bugs
Open

fix(uptimekuma): fix critical bugs in pull mode and webhook handling#5641
ART-R2D275 wants to merge 1 commit intokeephq:mainfrom
ART-R2D275:fix/uptimekuma-provider-bugs

Conversation

@ART-R2D275
Copy link

@ART-R2D275 ART-R2D275 commented Feb 17, 2026

Summary

Fix critical bugs in UptimeKuma provider for both pull mode and webhook handling.

Fixes #5655

Changes

Bug Fixes

  • Fix heartbeats.append() outside for-loop — Only last monitor was being reported instead of all monitors
  • Fix _format_datetime string concatenation — Was causing TypeError
  • Fix webhook _format_alert referencing non-existent fields — Was causing KeyError on every webhook

Improvements

  • Add AlertSeverity mapping from Uptime Kuma status codes
  • Add FINGERPRINT_FIELDS for proper alert deduplication
  • Add try/finally for connection cleanup
  • Add bulk monitor fetching for better performance
  • Add STATUS_MAP with both numeric and string key support

Testing

  • Tested pull mode with multiple monitors
  • Tested webhook payload handling
  • Verified connection cleanup

- Fix heartbeats.append() outside for-loop (only last monitor reported)
- Fix _format_datetime string concatenation causing TypeError
- Fix webhook _format_alert referencing non-existent fields (KeyError)
- Add AlertSeverity mapping from Uptime Kuma status codes
- Add FINGERPRINT_FIELDS for proper alert deduplication
- Add try/finally for connection cleanup
- Add bulk monitor fetching for better performance
- Add STATUS_MAP with both numeric and string key support
@vercel
Copy link

vercel bot commented Feb 17, 2026

@ART-R2D275 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 17, 2026
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Target branch is not in the allowed branches list.

@ART-R2D275
Copy link
Author

Hi maintainers 👋

The CLA assistant bot is requesting a signature, but when I try to sign at https://cla-assistant.io/keephq/keep it returns:

"There is no CLA to sign for keephq/keep (Not Found)"

Could you help resolve this? Happy to sign if there's a working link.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: UptimeKuma provider has multiple critical bugs in pull mode and webhook handling

2 participants