Skip to content

fix: generate UUID for prometheus alerts when id is not a valid uuid #6219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DragonBot00 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix: generate UUID for prometheus alerts when id is not a valid uuid #6219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion keep/providers/prometheus_provider/prometheus_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import dataclasses
import datetime
import os
import uuid as uuid_module

import pydantic
import requests
Expand Down Expand Up @@ -179,7 +180,16 @@ def _format_alert(
alerts = event.get("alerts", [event])

for alert in alerts:
alert_id = alert.get("id", alert.get("labels", {}).get("alertname"))
raw_id = alert.get("id")
if raw_id:
try:
uuid_module.UUID(str(raw_id))
alert_id = raw_id
except (ValueError, AttributeError):
alert_id = str(uuid_module.uuid4())
else:
alert_name = alert.get("labels", {}).get("alertname")
alert_id = alert_name if alert_name else str(uuid_module.uuid4())
description = alert.get("annotations", {}).pop(
"description", None
) or alert.get("annotations", {}).get("summary", alert_id)
Expand Down
Loading